Enable Kotlin warnings as errors (#58390) - #58390
Closed
javache wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119096917. |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#58390 K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable `warnings_as_errors_k22` by default for `rn_android_library` and clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source. Changelog: [Internal] Differential Revision: D119096917
javache
force-pushed
the
export-D119096917
branch
from
September 7, 2026 19:45
e36951a to
5fd0d44
Compare
meta-codesync
Bot
changed the title
cortinico
approved these changes
Sep 8, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#58390 K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable `warnings_as_errors_k22` by default for `rn_android_library` and clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119096917
javache
force-pushed
the
export-D119096917
branch
2 times, most recently
from
September 8, 2026 12:14
c7e29f4 to
03613dc
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#58390 K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable `warnings_as_errors_k22` by default for `rn_android_library` and clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119096917
javache
force-pushed
the
export-D119096917
branch
from
September 9, 2026 13:00
03613dc to
25b2323
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#58390 K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable `warnings_as_errors_k22` by default for `rn_android_library` and clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119096917
Summary: Pull Request resolved: react#58390 K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable `warnings_as_errors_k22` by default for `rn_android_library` and clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119096917
javache
force-pushed
the
export-D119096917
branch
from
September 9, 2026 13:08
25b2323 to
2f90d84
Compare
|
This pull request has been merged in eba7f28. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable
warnings_as_errors_k22by default forrn_android_libraryand clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D119096917